Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should remove new when using busboy #2557

Closed
Youlean opened this issue Feb 21, 2022 · 2 comments
Closed

Should remove new when using busboy #2557

Youlean opened this issue Feb 21, 2022 · 2 comments
Assignees
@sofisl
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@Youlean
Copy link

Youlean commented Feb 21, 2022 •
edited
Loading

nodejs-docs-samples/functions/http/index.js

Line 127 in d689fe5

const busboy = new Busboy({headers: req.headers});

The "new" should be removed for the latest version of busboy
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 21, 2022
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Feb 22, 2022
@chingor13 chingor13 added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed type: cleanup An internal cleanup or hygiene concern. labels Feb 22, 2022
@chingor13
Copy link
Member

Breaking changes notes from 1.0.0: mscdex/busboy#266

@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Feb 22, 2022
@averikitsch
Copy link
Contributor

fixed in #2564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sofisl sofisl

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chingor13 @averikitsch @Youlean @yoshi-automation @sofisl