Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing header for FHIR examples #3698

Open
nate-watkins opened this issue May 14, 2024 · 1 comment
Open

Missing header for FHIR examples #3698

nate-watkins opened this issue May 14, 2024 · 1 comment
Assignees
Labels
api: healthcare Issues related to the Cloud Healthcare API API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@nate-watkins
Copy link

nate-watkins commented May 14, 2024

In which file did you encounter the issue?

healthcare/fhir/createFhirResource.js

Did you change the file? If so, how?

    version: 'v1',
    auth: new google.auth.GoogleAuth({
      scopes: ['https://www.googleapis.com/auth/cloud-platform'],
    }),
    headers: {'Content-Type': 'application/fhir+json'},
+   responseType: 'json',
   }
}

Describe the issue

Line 58 expects the return type to be json. If left unspecified, it returns an array buffer that needs to be converted. This applies to many of the FHIR examples. For others who may come across this, I believe there are other issues with the TS types in the client library.

@nate-watkins nate-watkins added priority: p2 Moderately-important priority. Fix may not be included in next release. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 14, 2024
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 14, 2024
@iennae
Copy link
Contributor

iennae commented Aug 13, 2024

@nate-watkins Thank you so much for both this issue and the one in the APIs repo. I'll follow up with folks in the Client Libraries team. Appreciate the context that you've shared.

@iennae iennae self-assigned this Aug 13, 2024
@iennae iennae added api: healthcare Issues related to the Cloud Healthcare API API. and removed triage me I really want to be triaged. labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: healthcare Issues related to the Cloud Healthcare API API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants