Needed to run a credentials helper for docker to make make push work

[draffensperger]

Thanks for making this great samples repo!

One small thing that seemed like it may have been a missing step. When I ran make setup it didn't actually seem to create the artifact repository for me - I created it manually.

I also needed to run gcloud auth configure-docker us-central1-docker.pkg.dev to authorize my local docker to talk to GCP artifact repository for make push command to work for me for the go app.

[aabmass]

When I ran make setup it didn't actually seem to create the artifact repository for me - I created it manually.

Do you remember what error you saw? It should be creating the artifact registry

opentelemetry-operator-sample/Makefile

Line 21 in 57b0741

gcloud artifacts repositories create ${CONTAINER_REGISTRY} --repository-format=docker --location=${REGISTRY_LOCATION} --description="OpenTelemetry Operator sample registry"

I also needed to run gcloud auth configure-docker us-central1-docker.pkg.dev to authorize my local docker to talk to GCP artifact repository for make push command to work for me for the go app.

👍 agreed, we should add it

[draffensperger]

I don't remember the exact error unfortunately, but if I hit it again I'll update here.