Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code signing-urls-manually #1092

Open
marcofbb opened this issue Apr 24, 2020 · 4 comments
Open

Add code signing-urls-manually #1092

marcofbb opened this issue Apr 24, 2020 · 4 comments
Labels
samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@marcofbb
Copy link

Hello,
I have translated the python code of this page https://cloud.google.com/storage/docs/access-control/signing-urls-manually to PHP

Could you add it to the documentation? I do not dare to request a pull

Link code PHP: https://gist.github.com/marcofbb/97c875bb51f2dc9740588f8e550aac77

Thanks

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 24, 2020
@bshaffer
Copy link
Contributor

bshaffer commented May 6, 2020

@marcofbb a Pull Request is the best way to contribute code. Why do you "not dare"? Here is some documentation on how to do this.

@bshaffer bshaffer added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. labels May 6, 2020
@bshaffer
Copy link
Contributor

bshaffer commented May 6, 2020

Also, I see you've defined two functions in that gist. One is for generate_signed_url_google and the other is for generate_signed_url (in the comment)

Which of these are you proposing we use?

@marcofbb
Copy link
Author

marcofbb commented May 6, 2020

Also, I see you've defined two functions in that gist. One is for generate_signed_url_google and the other is for generate_signed_url (in the comment)

Which of these are you proposing we use?

Hello,
First generate_signed_url_google(); there function is equal to function in docs with Python

I have to make an improvement, which is to use the PHP class date, so as not to edit the general timezone of the php running

The function is translate python to PHP of code: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/storage/signed_urls/generate_signed_urls.py

Greats

@marcofbb
Copy link
Author

marcofbb commented May 6, 2020

@marcofbb a Pull Request is the best way to contribute code. Why do you "not dare"? Here is some documentation on how to do this.

Because I don't know which path to upload it to, the path for the PHP example code is not generated for this

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants