KMS Asymmetric Text Fixes #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
daniel-sanche
force-pushed
the
kms-fixes
branch
from
f4dd0e9 to
dd172a5
Compare
engelke
approved these changes
Aug 21, 2018
There was a problem hiding this comment.
I recommend adding a sentence or two at the top explaining that operations involving private keys (decryption and signing) are performed by KMS without exposing those keys, while operations requiring public keys are done with any standard cryptographic library.
But that's a suggestion for the future. As to the rest, LGTM.
busunkim96
pushed a commit
to googleapis/python-kms
that referenced
this pull request
Jun 4, 2020
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
8 tasks
rsamborski
pushed a commit
that referenced
this pull request
Nov 8, 2022
rsamborski
pushed a commit
that referenced
this pull request
Nov 11, 2022
rsamborski
pushed a commit
that referenced
this pull request
Nov 14, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 14, 2022
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues in the documentation of the last KMS PR: