Skip to content

Conversation

@dizcology
Copy link
Member

add multichannel samples and tests

@dizcology dizcology requested a review from nnegrey February 6, 2019 20:56
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 6, 2019
Copy link
Contributor

@nnegrey nnegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the high level comments in the file need to be updated.

# limitations under the License.

"""Google Cloud Speech API sample that demonstrates enhanced models
and recognition metadata.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment update

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Example usage:
python transcribe_multichannel.py resources/audio.raw
python transcribe_multichannel.py \
gs://cloud-samples-tests/speech/Google_Gnome.wav
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put this in the storage-samples project?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dizcology
Copy link
Member Author

dizcology commented Feb 11, 2019

the sample tests are currently failing on the service side.

UPDATE: tests passing.

@dizcology dizcology requested a review from nnegrey February 22, 2019 15:15
@nnegrey nnegrey merged commit 717edb3 into GoogleCloudPlatform:master Feb 22, 2019
busunkim96 pushed a commit to busunkim96/python-speech that referenced this pull request Sep 1, 2020
…hon-docs-samples#2003)

* add speech api multichannel samples

* udpate copyright year

* test with multichannel audio data

* flake

* update comment
busunkim96 pushed a commit to googleapis/python-speech that referenced this pull request Sep 3, 2020
…hon-docs-samples#2003)

* add speech api multichannel samples

* udpate copyright year

* test with multichannel audio data

* flake

* update comment
telpirion pushed a commit that referenced this pull request Jan 13, 2023
* add speech api multichannel samples

* udpate copyright year

* test with multichannel audio data

* flake

* update comment
dandhlee pushed a commit that referenced this pull request Feb 9, 2023
* add speech api multichannel samples

* udpate copyright year

* test with multichannel audio data

* flake

* update comment
telpirion pushed a commit that referenced this pull request Mar 13, 2023
* add speech api multichannel samples

* udpate copyright year

* test with multichannel audio data

* flake

* update comment
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
…hon-docs-samples#2003)

* add speech api multichannel samples

* udpate copyright year

* test with multichannel audio data

* flake

* update comment
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
…hon-docs-samples#2003)

* add speech api multichannel samples

* udpate copyright year

* test with multichannel audio data

* flake

* update comment
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 18, 2023
…hon-docs-samples#2003)

* add speech api multichannel samples

* udpate copyright year

* test with multichannel audio data

* flake

* update comment
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 22, 2023
…hon-docs-samples#2003)

* add speech api multichannel samples

* udpate copyright year

* test with multichannel audio data

* flake

* update comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants