-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add voice selection by name #2687
Merged
texasmichelle
merged 11 commits into
GoogleCloudPlatform:master
from
texasmichelle:tts_b_143877133
Jan 11, 2020
Merged
Add voice selection by name #2687
texasmichelle
merged 11 commits into
GoogleCloudPlatform:master
from
texasmichelle:tts_b_143877133
Jan 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jan 7, 2020
It looks like 2.7 is failing because
|
Fixes python2 test failures referencing html.
…s-samples into tts_b_143877133
If these tests are running repo-wide, would it make sense to add |
Per @leahecole, best to keep |
busunkim96
approved these changes
Jan 11, 2020
busunkim96
pushed a commit
to googleapis/python-texttospeech
that referenced
this pull request
Apr 9, 2020
…-samples#2687) * Add voice selection by name * Add future to requirements.txt Fixes python2 test failures referencing html. Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96
pushed a commit
to googleapis/python-texttospeech
that referenced
this pull request
May 13, 2020
…-samples#2687) * Add voice selection by name * Add future to requirements.txt Fixes python2 test failures referencing html. Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96
pushed a commit
to googleapis/python-texttospeech
that referenced
this pull request
May 13, 2020
…-samples#2687) * Add voice selection by name * Add future to requirements.txt Fixes python2 test failures referencing html. Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96
pushed a commit
to googleapis/python-texttospeech
that referenced
this pull request
May 13, 2020
…-samples#2687) * Add voice selection by name * Add future to requirements.txt Fixes python2 test failures referencing html. Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96
pushed a commit
to googleapis/python-texttospeech
that referenced
this pull request
May 20, 2020
…-samples#2687) * Add voice selection by name * Add future to requirements.txt Fixes python2 test failures referencing html. Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96
pushed a commit
to googleapis/python-texttospeech
that referenced
this pull request
May 20, 2020
…-samples#2687) * Add voice selection by name * Add future to requirements.txt Fixes python2 test failures referencing html. Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
msampathkumar
pushed a commit
that referenced
this pull request
Nov 10, 2022
8 tasks
msampathkumar
pushed a commit
that referenced
this pull request
Nov 10, 2022
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Sep 22, 2023
…-samples#2687) * Add voice selection by name * Add future to requirements.txt Fixes python2 test failures referencing html. Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Sep 22, 2023
…-samples#2687) * Add voice selection by name * Add future to requirements.txt Fixes python2 test failures referencing html. Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add name parameter based on user request.
b/143877133