Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotations not properly handled in flag options (ex: --pip-cmd=...) #686

Open
aaron-prindle opened this issue Jun 19, 2018 · 0 comments
Open

Quotations not properly handled in flag options (ex: --pip-cmd=...) #686

aaron-prindle opened this issue Jun 19, 2018 · 0 comments
Labels
ftl

Comments

@aaron-prindle
Copy link
Collaborator

aaron-prindle commented Jun 19, 2018 •
edited
Loading

Recently a consumer of FTL attempted to use --pip-cmd=... with a command with quotes in it. When launching the command FTL did not interpret the quotes properly for the command, causing an error. The error message that was displayed https://github.com/GoogleCloudPlatform/runtimes-common/blob/master/ftl/common/ftl_util.py#L280 was not helpful
@aaron-prindle aaron-prindle changed the title FTL Issue: Quotations in arguments (ex: --pip-cmd=...) can break FTL FTL Issue: Quotations not properly handled in flag options (ex: --pip-cmd=...) Jun 19, 2018
@aaron-prindle aaron-prindle changed the title FTL Issue: Quotations not properly handled in flag options (ex: --pip-cmd=...) Quotations not properly handled in flag options (ex: --pip-cmd=...) Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ftl
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaron-prindle