Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add property to customize universe domain in Pub/Sub #3348

Merged
merged 5 commits into from
Nov 1, 2024

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Oct 28, 2024

Notable Changes:

  • Adds subscription-specific property for universe domain to customize Subscriber
  • Adds global subscriber property for universe domain. In terms of priority. The subscription-specific property takes precedence if both global and subscription-specific properties are set. If subscription-specific configuration is not set then the global configuration is picked.
  • Adds global publisher property for universe domain to customize Publisher.

Verified behavior manually in separate test plan document.

@mpeddada1 mpeddada1 marked this pull request as ready for review October 29, 2024 15:43
@mpeddada1 mpeddada1 requested a review from a team as a code owner October 29, 2024 15:43
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
54.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@mpeddada1 mpeddada1 merged commit 9cf2145 into main Nov 1, 2024
71 of 76 checks passed
@mpeddada1 mpeddada1 deleted the pubsub-universeDomain branch November 1, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants