Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: build script tweaks for non-standard libraries #238

Merged
merged 2 commits into from
May 3, 2019
Merged

build: build script tweaks for non-standard libraries #238

merged 2 commits into from
May 3, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 2, 2019

  1. in lint.sh only npm install in samples directory if a samples/package.json exists.
  2. in samples-test.sh only run samples tests if a samples/package.json exists.
  3. ini test.sh only pipe coverage to codecov if on Node 10, don't try to run nyc if it doesn't exist (allowing us to opt for c8 in some cases).

@bcoe bcoe requested review from JustinBeckwith and jkwlui May 2, 2019 23:54
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 2, 2019
@bcoe bcoe changed the title build: minor build script tweaks for non-standard libraries build: build script tweaks for non-standard libraries May 2, 2019
@bcoe bcoe merged commit ee3316b into master May 3, 2019
@bcoe bcoe deleted the script-tweaks branch May 3, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@jkwlui jkwlui Awaiting requested review from jkwlui

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcoe @JustinBeckwith @googlebot