Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support .NET distroless #83

Closed
salrashid123 opened this issue Aug 15, 2017 · 5 comments
Closed

Support .NET distroless #83

salrashid123 opened this issue Aug 15, 2017 · 5 comments

Comments

@salrashid123
Copy link
Contributor

FR to support coreCLR distroless builds once we actually support coreCLR in bazel

FWIW, here's a sample coreCLR distroless build where the coreCLR binary is generated outside of bazel

@mattmoor
Copy link
Contributor

We don't support Node in Bazel, and yet we have a distroless image. Up for a PR?

@salrashid123
Copy link
Contributor Author

I don't mind submitting the PR. Do you think there is use in a distroless build where the actual binary is build outside of bazel? I can see where bazel is just the mechanism used here for distroless builds so there isn't technically a dependency or requirement we have .NET in bazel first before .net w/ distroless. If that sounds good, i'll fine sometime to submit the PR.

@colemickens
Copy link

Personally, I think so. I could convert all of my build to Bazel except some bash to drive the .NET Core 2 build until the dotnet rules evolve .NET Core 2 support.

@salrashid123
Copy link
Contributor Author

salrashid123 commented Aug 27, 2017

ok, fwiw, submitted PR #88 but pls ignore for now (its failing the CI builds....)

(from fork/branch here

@salrashid123
Copy link
Contributor Author

PR88 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants