-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add layer description history #1198
Add layer description history #1198
Conversation
Thanks for the contribution! @GoogleContainerTools/java-tools What do you think about having the layer type be the |
Adding the layer type looks good. |
+1 |
I think this makes more sense too, I'll change this to work like that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to add to the comments in this PR, would prefer something like
IMAGE CREATED CREATED BY SIZE COMMENT
dcfe658ad0b2 48 years ago jib-gradle-plugin 2.17kB classes
<missing> 48 years ago jib-gradle-plugin 1.54MB dependencies
With minimal string processing on the comment
value.
jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/BuildImageStep.java
Outdated
Show resolved
Hide resolved
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
CLAs look good, thanks! |
Changed to add the layer type on the comments and without capitalizing it, so the updated example is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Would you mind adding entries to the CHANGELOG.md for jib-gradle-plugin
and jib-maven-plugin
?
jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/BuildImageStepTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think when the nits are fixed it should be good for approval/merging
jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/BuildImageStepTest.java
Outdated
Show resolved
Hide resolved
@coollog @TadCordle discussions were resolved and also added to the change log. I think it is fine now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I think we can get this merged soon.
This closes the issue #1179 adding the descriptions ('Classes', 'Dependencies', 'Resources' and 'Extra files') to the layer history.
Example: