-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support retries to push to a registry #1409
Comments
#691 is related, although that isn't about dealing with 504. |
We should also investigate using chunked uploads since some layers may be rather huge. The only worrisome aspect is that it's unclear what should be our minimum chunk size:
It appears that chunks must be provided in sequence. The documentation describing the 416 result says:
|
up? on openshift we easily get SSL issues (indeed without any modification a relaunch works) when pushing concurrently layers so a proper retry would help on client side. edit: checked that just looping inside com.google.cloud.tools.jib.registry.RegistryEndpointCaller#call(java.net.URL) (potentially with a jitter) to retry solves the mentionned issue. A default of 3 retries sounds very acceptable or alternatively a max duration per push (if the image push didn't suceed in 10mn, don't retry anymore anything for ex). |
Description of the issue:
On laggy registries - which means you often get a 504 timeout issue - it is not possible to push images with jib whereas it works with docker with a retry (it retries not yet uploaded layers).
Expected behavior:
A retry would happen on layers (default to 3 maybe?).
The text was updated successfully, but these errors were encountered: