Make intermediate build config available #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
commented
Oct 31, 2019
|
|
||
| /** | ||
| * A class containing the representation of the contents of a container. Currently only exposes | ||
| * "layers", but can be extended to expose {@link ContainerConfiguration} or other informational |
There was a problem hiding this comment.
As this comment notes, ContainerConfiguration is left out... it's not in API, but maybe we can put it in API?
chanseokoh
reviewed
Oct 31, 2019
jib-maven-plugin/src/test/java/com/google/cloud/tools/jib/maven/skaffold/SyncMapMojoTest.java
Outdated
Show resolved
Hide resolved
jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/skaffold/SyncMapMojo.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/api/JibContainerDescription.java
Show resolved
Hide resolved
| this.layers = ImmutableList.copyOf(layers); | ||
| } | ||
|
|
||
| /** Returns a list of "user configured" layers, does *not* include base layer information. */ |
There was a problem hiding this comment.
Ah, this is revealing. Maybe getAddedLayers() is more aptly named?
loosebazooka
force-pushed
the
refactor-for-intermediate-config
branch
from
de82080 to
59a0a97
Compare
chanseokoh
reviewed
Nov 1, 2019
|
|
||
| /** | ||
| * Returns a list of "user configured" layers, does *not* include base layer information. | ||
| * @return An {@link ImmutableList} of {@link LayerConfiguration}s |
There was a problem hiding this comment.
Doesn't ./gradlew javadoc complain how having a newline before @return? And did you consider the name getAddedLayers()? I think it's lower the chance to mistakenly assume they include base image layers.
There was a problem hiding this comment.
yeah, I guess I hadn't rebased by then.
loosebazooka
force-pushed
the
refactor-for-intermediate-config
branch
from
dc169a8 to
efb4bff
Compare
chanseokoh
approved these changes
Nov 1, 2019
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fewest changes to expose layers that I could think of.