Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail and surface tar build error when jib:dockerBuild and jib:build #633

Closed
chanseokoh opened this issue Jul 17, 2018 · 3 comments
Closed
Assignees
Milestone

Comments

@chanseokoh
Copy link
Member

From #626. The execution of jib:dockerBuild becomes stuck.

Finalizing...
Loading to Docker daemon...
<==========---> 83% EXECUTING [1h 19m 22s]

Would be easy to reproduce with jib:dockerBuild by throwing an artificial exception as #626 did originally.

Also, I vaguely remember jib:build did not fail but rather succeeded, which is more concerning.

@coollog coollog added this to the v0.9.8 milestone Jul 17, 2018
@TadCordle
Copy link
Contributor

Wait, is the issue here that #626 isn't actually fixed, or just that we need better error feedback if this happens again?

@chanseokoh
Copy link
Member Author

chanseokoh commented Jul 17, 2018

Sorry if it wasn't clear. I expect the underlying issue of #626 (incorrect handling of milti-byte strings) has been fixed. This issue is about not failing but the execution getting stuck forever or appearing to succeed when there was any kind of errors actually building tars.

@coollog coollog removed this from the v0.9.8 milestone Jul 24, 2018
@coollog coollog added this to the v0.11.0 milestone Aug 29, 2018
@coollog coollog modified the milestones: v1.1.0, v1.0.0 Nov 9, 2018
@TadCordle TadCordle self-assigned this Dec 10, 2018
@TadCordle
Copy link
Contributor

TadCordle commented Dec 10, 2018

I was able to test this by temporarily reintroducing the problem in #626, and the problem seems to be fixed for the jib:dockerBuild case (probably by #1064). jib:build still succeeds though, but that's because jib:build doesn't ever call the code where the original error occurred (TarStreamBuilder#addByteEntry, formerly TarStreamBuilder#addEntry, which is used by ImageToTarballTranslator, which is only ever used by LoadDockerStep and WriteTarFileStep). So I suspect there's no problem here, especially since we haven't hit this since July.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants