Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshotting is taking more than 10 mins. #1282

Closed
tejal29 opened this issue May 23, 2020 · 1 comment · Fixed by #1283
Closed

Snapshotting is taking more than 10 mins. #1282

tejal29 opened this issue May 23, 2020 · 1 comment · Fixed by #1283

Comments

@tejal29
Copy link
Member

tejal29 commented May 23, 2020

Actual behavior
Snapshotting FS should for a Node js project with npm install command should be faster than current.

Expected behavior
Looks like TakeSnapshotFS is a bottleneck for projects with huge number of files.
e.g .for a project with file count 800K, the TakeSnapshotFS takes almost 15-20 mins.

After some investigation, i found out we loop over files multiple times. In this PR, we are reducing the number of times we loop over the files.

@sameersbn
Copy link

I am facing this issue as well. this step takes the most number of cycles in my builds. optimizing this will greatly reduce the build time of ALL my images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants