Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug-* tags don't follow semantic version #1448

Closed
dmaciel opened this issue Oct 4, 2020 · 6 comments · Fixed by #1460
Closed

debug-* tags don't follow semantic version #1448

dmaciel opened this issue Oct 4, 2020 · 6 comments · Fixed by #1460
Labels
good first issue Good for newcomers help wanted Looking for a volunteer! priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@dmaciel
Copy link

dmaciel commented Oct 4, 2020

I'm working on a tool to check for update on containers and for parsing versions I'm using this library https://github.com/hashicorp/go-version

The debug-* images don't follow semver and the library is not able to process them, will it be possible to switch the "debug" string at the end? so instead of debug-v1.2.0 we can have v1.2.0-debug (or v1.2.0+debug if we use it as metadata). Technically the 'v' in the front is not semver compliant neither, but at least the library is able to handle that case.

There is not need to delete the "debug-" tag, but having "-debug" or "*+debug" will be helpful for scripting

@tejal29
Copy link
Contributor

tejal29 commented Oct 6, 2020

sure. we can provide that.
You could easily do that by making a change to this cloudbuild.yaml to create another tag
https://github.com/GoogleContainerTools/kaniko/blob/master/deploy/cloudbuild-release.yaml#L24

@tejal29 tejal29 added help wanted Looking for a volunteer! good first issue Good for newcomers priority/p3 agreed that this would be good to have, but no one is available at the moment. labels Oct 6, 2020
@sladyn98
Copy link
Contributor

@tejal29 @dmaciel Would love to send in a PR for this.

 name: "gcr.io/cloud-builders/docker"
    args: ["tag", "gcr.io/kaniko-project/warmer:$TAG_NAME", 
           "gcr.io/kaniko-project/warmer:latest"]

What new tags would I need to add here ?

@tejal29
Copy link
Contributor

tejal29 commented Oct 14, 2020

The warmer image is fine i guess.
you will have to do the following for the debug image.
you will have to make this change in 2 files. couldbuild-release.yaml and cloudbuild.yaml

  - name: "gcr.io/cloud-builders/docker"
    args: ["tag", "gcr.io/kaniko-project/executor:debug-$TAG_NAME", 
           "gcr.io/kaniko-project/executor:$TAG_NAME-debug"]

The above command will run
docker tag gcr.io/kaniko-project/executor:debug-v1.2.0 gcr.io/kaniko-project/executor:v1.2.0-debug

@tejal29
Copy link
Contributor

tejal29 commented Oct 14, 2020

Oh and in the images

images: ["gcr.io/kaniko-project/executor:$TAG_NAME",
         "gcr.io/kaniko-project/executor:latest",
         "gcr.io/kaniko-project/executor:debug-$TAG_NAME",
         "gcr.io/kaniko-project/executor:debug",
         "gcr.io/kaniko-project/warmer:$TAG_NAME",
         "gcr.io/kaniko-project/warmer:latest"]

Add the newly tagged gcr.io/kaniko-project/executor:$TAG_NAME-debug

@sladyn98
Copy link
Contributor

Sounds good 👍

@sladyn98 sladyn98 mentioned this issue Oct 19, 2020
4 tasks
@sladyn98
Copy link
Contributor

I created a PR for this @tejal29 . Thanks for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Looking for a volunteer! priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants