-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kaniko does not honor copy regex #757
Comments
@flixpae Currently kaniko does not support reg-ex in copy command. |
This issue is still not fixed. Any timeline around this? |
After some investigation, seems the COPY command does accept wildcards with the mathSources in command_util; similarly for ADD. The wildcard implementations shall precede this issue was raised. Looking into the reason why this actually failed, but with v1.16.0 image. |
Also tried * and []. Looks like this shall work with what's supported with |
Suggesting this could be closed for now with the support of {?*[} which corresponds to the docker build matching patterns. |
Just validated that this functionality indeed works @ HEAD using the repro above: Repro Dockerfile + file tree:
From the above you can see the file |
Actual behavior
A clear and concise description of what the bug is.
I am in the process of integrating kaniko in a custom image for use in gitlab-ci
I tried to exclude contents with a filepath.Match pattern as stated in the docker docs
https://docs.docker.com/engine/reference/builder/#copy
But Kaniko copys all contents regardless of the preceding match pattern
Expected behavior
A clear and concise description of what you expected to happen.
Kaniko should honor the supplied match pattern as "docker build" does.
To Reproduce
Steps to reproduce the behavior:
Additional Information
Please provide either the Dockerfile you're trying to build or one that can reproduce this error.
Please provide or clearly describe any files needed to build the Dockerfile (ADD/COPY commands)
The text was updated successfully, but these errors were encountered: