Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --image-name-with-digest-file #814

Closed
Ark-kun opened this issue Oct 12, 2019 · 2 comments · Fixed by #841
Closed

Add --image-name-with-digest-file #814

Ark-kun opened this issue Oct 12, 2019 · 2 comments · Fixed by #841
Labels
area/cli bugs related to kaniko CLI good first issue Good for newcomers priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@Ark-kun
Copy link

Ark-kun commented Oct 12, 2019

I request a small new feature very similar to the existing --digest-file option.
The --digest-file option only outputs the image digest (sha256:bc45...67e1) and needs to be combined with image name to make a working image reference.

The --image-name-with-digest-file should output the full image name including the digest: my-org/my-image@sha256:bc45...67e1

@tejal29
Copy link
Contributor

tejal29 commented Oct 16, 2019

@Ark-kun, since the user specifies the image name in the --destination flag, can you write a script to append the image name?

@tejal29 tejal29 added area/cli bugs related to kaniko CLI good first issue Good for newcomers priority/p3 agreed that this would be good to have, but no one is available at the moment. labels Oct 16, 2019
@Ark-kun
Copy link
Author

Ark-kun commented Oct 16, 2019

can you write a script to append the image name?

I tried that, but the Kaniko container image is distroless and does not have sh.

Generally, I think that the full image name is more useful than just digest alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli bugs related to kaniko CLI good first issue Good for newcomers priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants