Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make images failes with build_args incorrectly populated #820

Closed
slmagus opened this issue Oct 16, 2019 · 0 comments · Fixed by #821
Closed

make images failes with build_args incorrectly populated #820

slmagus opened this issue Oct 16, 2019 · 0 comments · Fixed by #821
Labels
area/internal bugs related to kaniko development workflow good first issue Good for newcomers priority/p0 Highest priority. Break user flow. We are actively looking at delivering it.

Comments

@slmagus
Copy link

slmagus commented Oct 16, 2019

Actual behavior
make images
docker build '' -t gcr.io/kaniko-project/executor:latest -f deploy/Dockerfile .
"docker build" requires exactly 1 argument.
See 'docker build --help'.

Usage: docker build [OPTIONS] PATH | URL | -

Build an image from a Dockerfile
Makefile:59: recipe for target 'images' failed
make: *** [images] Error 1
travis_time:end:28e7a5e0:start=1571237555923107306,finish=1571237556202595257,duration=279487951,event=script
�[0K�[31;1mThe command "make images" exited with 2.�[0m

Expected behavior
docker build command should not include anything if $BUILD_ARGS is empty

To Reproduce
run make images from master

Additional Information
Easily fixed by remove '' from BUILD_ARGS ?=
@slmagus slmagus mentioned this issue Oct 16, 2019
Merged
4 tasks
@tejal29 tejal29 added area/cli bugs related to kaniko CLI area/internal bugs related to kaniko development workflow good first issue Good for newcomers priority/p0 Highest priority. Break user flow. We are actively looking at delivering it. and removed area/cli bugs related to kaniko CLI labels Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/internal bugs related to kaniko development workflow good first issue Good for newcomers priority/p0 Highest priority. Break user flow. We are actively looking at delivering it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix build_args in MakeFile, have Travis run make images to preven issue in future slmagus/kaniko
2 participants
@tejal29 @slmagus