Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help message indicating {create,delete}-firewall is not necessary #6

Open
ahmetb opened this issue Oct 8, 2018 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@ahmetb
Copy link

ahmetb commented Oct 8, 2018

First time I ran kubehost -h these commands confused me:

  create-firewall <service>  : Create a GCP firewall rule for the hostPort
                               deployment created with 'bind'.
  delete-firewall <service>  : Delete a GCP firewall rule for the hostPort
                               deployment created with 'bind'.

I think they are "not needed" if you're using bind/unbind.

Please consider adding a note to these cmds saying something in the lines of:

Not needed if you use bind/unbind.

@WilliamDenniss WilliamDenniss added the enhancement New feature or request label Oct 9, 2018
@WilliamDenniss
Copy link
Collaborator

Good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants