Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch for helm chart changes #235

Closed
gmorse81 opened this issue Mar 19, 2018 · 3 comments
Closed

Watch for helm chart changes #235

gmorse81 opened this issue Mar 19, 2018 · 3 comments

Comments

@gmorse81
Copy link
Contributor

Skaffold currently only watches for changes happening within a Dockerfile. Since Skaffold already supports helm deployments, it would be great if the helm chart location could be identified as an artifact so if the chart templates are changed, it would kick off a new build.

I am currently working around this by copying the chart itself to the docker image. obviously not a permanent solution since this bloats the final docker image.

@r2d4
Copy link
Contributor

r2d4 commented Mar 19, 2018

Yes, we need this for all deployers.

The way I envision this working is that the Deploy interface now has another function

(*Deployer) Dependencies() ([]string, error)

The deployers would be responsible for using the deploy config to output a list of dependencies that should be watched by skaffold.

Of course, this relies on some work that I'll be doing to decouple watch from artifacts, since only artifacts can be watched right now.

@gmorse81
Copy link
Contributor Author

Awesome. Yes that would be great.

Great work on this project BTW. it's already doing great things for my local dev setup.

@r2d4
Copy link
Contributor

r2d4 commented Jun 29, 2018

Fixed by #765

@r2d4 r2d4 closed this as completed Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants