Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync not working with profiles #2407

Closed
gaetansnl opened this issue Jul 4, 2019 · 2 comments · Fixed by #2415
Closed

Sync not working with profiles #2407

gaetansnl opened this issue Jul 4, 2019 · 2 comments · Fixed by #2415
Assignees
Labels

Comments

@gaetansnl
Copy link

gaetansnl commented Jul 4, 2019

Expected behavior

I expect sync to work when it's configured in a profile

Actual behavior

Skaffold trigger full rebuild

Information

  • Skaffold version: 0.33.0
  • Operating system: Windows 10

Steps to reproduce the behavior

  1. Sync Working
apiVersion: skaffold/v1beta7
kind: Config
build:
  artifacts:
    - image: ********************
      context: .
      sync:
        'packages/server/***': ./
      docker:
        target: server-dev
        dockerfile: ./k8s/image/Dockerfile
  local:
    useBuildkit: true
deploy:
  kustomize:
    path: ./k8s/env-specific/internal-dev
  1. Sync not working (skaffold trigger full rebuild)
apiVersion: skaffold/v1beta7
kind: Config
profiles:
  - name: dev
    build:
      artifacts:
        - image: ***************
          context: .
          sync:
            'packages/server/***': ./
          docker:
            target: server-dev
            dockerfile: ./k8s/image/Dockerfile
      local:
        useBuildkit: true
    deploy:
      kustomize:
        path: ./k8s/env-specific/internal-dev

@dgageot dgageot added area/profiles area/sync kind/bug Something isn't working labels Jul 5, 2019
@dgageot dgageot self-assigned this Jul 5, 2019
@dgageot
Copy link
Contributor

dgageot commented Jul 5, 2019

@gaetansnl Sorry, there's an issue with the schema upgrade process.

When your config file is upgraded from v1beta7 to v1beta12, it loses the sync information that are carried by the profiles. If you manually migrate to v1beta12 and use the new syntax for sync, it should be all good.

ping @corneliusweig This should be done on profiles too

@corneliusweig
Copy link
Contributor

Sorry, my blunder. Will be fixed by #2415.

Thanks @gaetansnl for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants