Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hardcoded config version in generate-pipeline testing. #2889

Closed
tejal29 opened this issue Sep 16, 2019 · 0 comments · Fixed by #2890
Closed

Fix hardcoded config version in generate-pipeline testing. #2889

tejal29 opened this issue Sep 16, 2019 · 0 comments · Fixed by #2890
Labels
kind/todo implementation task/epic for the skaffold team meta/testing Issues focused on testing Skaffold itself

Comments

@tejal29
Copy link
Contributor

tejal29 commented Sep 16, 2019

Expected behavior

When generating a new skaffold version, all integration tests should pass as is.

Actual behavior

On Pr #2881, the following integration test failed

--- FAIL: TestGeneratePipeline (0.27s)
    --- PASS: TestGeneratePipeline/no_profiles (0.06s)
    --- PASS: TestGeneratePipeline/existing_oncluster_profile (0.05s)
    --- PASS: TestGeneratePipeline/existing_other_profile (0.08s)
    --- PASS: TestGeneratePipeline/multiple_skaffold.yamls_to_create_pipeline_from (0.05s)
    --- FAIL: TestGeneratePipeline/user_example (0.03s)
        generate_pipeline_test.go:139: Contents of examples/generate-pipeline/skaffold.yaml did not match those of examples/generate-pipeline/expectedSkaffold.yaml
            got:apiVersion: skaffold/v1beta15
            kind: Config
            build:
              artifacts:
              - image: gcr.io/k8s-skaffold/pipeline-example
            deploy:
              kubectl:
                manifests:
                - k8s-*
            profiles:
            - name: oncluster
              build:
                artifacts:
                - image: gcr.io/k8s-skaffold/pipeline-example-pipeline
                  context: .
                  kaniko:
                    buildContext:
                      gcsBucket: skaffold-kaniko
                tagPolicy:
                  gitCommit: {}
                cluster:
                  pullSecretName: kaniko-secret
            want:apiVersion: skaffold/v1beta14
            kind: Config
            build:
              artifacts:
              - image: gcr.io/k8s-skaffold/pipeline-example
            deploy:
              kubectl:
                manifests:
                - k8s-*
            profiles:
            - name: oncluster
              build:
                artifacts:
                - image: gcr.io/k8s-skaffold/pipeline-example-pipeline
                  context: .
                  kaniko:
                    buildContext:
                      gcsBucket: skaffold-kaniko
                tagPolicy:
                  gitCommit: {}
                cluster:

We don't need to compare skaffold.yaml as there are other integration tests that do that.

Information

  • Skaffold version: version...
  • Operating system: ...
  • Contents of skaffold.yaml:
<paste your skaffold.yaml here>

Steps to reproduce the behavior

  1. a clonable repository with the sample skaffold project
  2. skaffold <command>
  3. ...
@tejal29 tejal29 added meta/testing Issues focused on testing Skaffold itself kind/todo implementation task/epic for the skaffold team labels Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/todo implementation task/epic for the skaffold team meta/testing Issues focused on testing Skaffold itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant