Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jib configuration block should allow explicitly setting type #2963

Closed
briandealwis opened this issue Oct 1, 2019 · 1 comment · Fixed by #2964
Closed

Jib configuration block should allow explicitly setting type #2963

briandealwis opened this issue Oct 1, 2019 · 1 comment · Fixed by #2964

Comments

@briandealwis
Copy link
Member

With #2808 we merged the jibMaven and jibGradle blocks into a single jib block where we determine the plugin-type based on the presence of key files like build.gradle. This isn't fool-proof and we should allow setting the value explicitly.

@briandealwis briandealwis added build/jib priority/p1 High impact feature/bug. labels Oct 1, 2019
@briandealwis
Copy link
Member Author

Note: #2808 uses an internal enum to represent the plugin type:

// PluginType defines the different supported Jib plugins.
type PluginType int
const (
// use `iota+1` so that 0 is an invalid value
JibMaven PluginType = iota + 1
JibGradle
)

I had originally placed this enum definition inside the schema package, with appropriate MarshalYAML() and UnmarshalYAML() functions. This supported validation during the unmarshalling phase, but the schema generator didn't support these enums and so I backed it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants