[Feature Request] Cloud Run deployment target

[hden]

It may not be a good fit for skaffold, but it would be very interesting if we can deploy to Cloud Run (managed) with a simple config file e.g.

apiVersion: skaffold/v1
kind: Config
build:
  # only build and deploy "world-service" on main profile
  artifacts:
  - image: gcr.io/k8s-skaffold/skaffold-world
    context: world-service
deploy:
  cloud_run:
    platform: managed
    region: asia-northeast1
    env:
        MYSQL_USER: foobar
        MYSQL_PASSWORD: berglas://my-bucket/mysql-password-dev
    cloudsql-instances:
        - foobar

[hden]

The go client for Cloud Run can be found here:
https://github.com/googleapis/google-api-go-client/blob/master/run/v1/run-gen.go

[nkubala]

hey @hden, just wanted to provide an update here. Skaffold largely powers the Cloud Code IDE extensions for VSCode and IntelliJ, which provide local development experiences for Kubernetes and GCP directly in the IDE. after months of design discussions we decided that Skaffold is not the right place to support Cloud Run, as want to stay focused on Kubernetes-native applications - however, the Cloud Code plugins have added their own support for iterative development against Cloud Run, and in fact this was just released in IntelliJ last week! VSCode will follow with their release very soon, so be sure and check those out if you're using an IDE :)

[nkubala]

going to reopen this as we've relaxed our principle on deployer extensibility, and will likely either accept a contribution for this or implement ourselves in the future.

[cgrotz]

Hi, I would like to give this a try. Okay?

[briandealwis]

@cgrotz this is actually a big piece of work, and there are a few different approaches being considered internally. So my advice is to hold off on this for now.

[krrrr38]

I hope this feature will be available on CloudDeploy.

[samos123]

Any updates on this @briandealwis ? I would love to be able to use Cloud Run / Knative with Skaffold.

[cgrotz]

I started a simple implementation on my fork. It allows to deploy to cloud run.

But there are a few things that are a little alien, since skaffold is build more with k8s in mind.

https://github.com/cgrotz/skaffold/tree/main/pkg%2Fskaffold%2Fdeploy%2Fcloudrun

[gmeans]

I was just curious about this feature because using Cloud Code w/ the Cloud Run emulator, it appears behind the scenes skaffold is being used.

Is this just one of the approaches @briandealwis mentioned being considered? Or the path chosen?

Thanks!

[briandealwis]

Cloud Run support has recently been added to Config Connector. Config Connector allows declarative configuration of GCP resources.

@gmeans the gcloud code dev creates and deploys a pod + service definition using Skaffold and Minikube.

@cgrotz that's nifty. It's unclear how to handle local development vs deploying the managed service. We could have skaffold dev or skaffold debug do local development, whereas you'd use skaffold deploy to upload the service to Cloud Run.

[cgrotz]

Thanks for sharing the Config Connector link, I was waiting for this but wasn't aware that this was already in alpha. 😃

@briandealwis thanks, but I get why you recommended to hold off on it (I already had made that POC by then). For cloud run we wouldn't have a separate render phase.

I think your idea for skaffold dev and skaffold debug is great. I think going with gcloud code dev would probably be the idiomatic approach. Let me try it out.

What caused me some headache was also the question whether the config should support multiple Cloud Run services. @briandealwis and @gmeans what's your opinion on that?

[aaron-prindle]

@bskaplan

[aaron-prindle]

Cloud Run deployment support was added in Skaffold v2.0.0 🎊. Closing this issue (fixed)