Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'skaffold debug' should support build triggers #3272

Closed
bmcustodio opened this issue Nov 19, 2019 · 5 comments · Fixed by #4089
Closed

'skaffold debug' should support build triggers #3272

bmcustodio opened this issue Nov 19, 2019 · 5 comments · Fixed by #4089
Assignees
Labels
area/debug kind/feature-request priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence.

Comments

@bmcustodio
Copy link
Contributor

skaffold debug is awesome, but as far as I understand it doesn't support "redeploy-on-change"—meaning that to debug a change one has to stop and restart skaffold debug, which may be a bit awkward. It would be great if skaffold debug would behave a bit more like skaffold dev. Thoughts?

@bmcustodio
Copy link
Contributor Author

BTW, I am not sure whether this is this a duplicate of #2351 or not—sorry if it is indeed.

@balopat balopat added kind/feature-request priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence. area/debug labels Nov 20, 2019
@balopat
Copy link
Contributor

balopat commented Nov 20, 2019

Hi @bmcstdio - thanks for opening this!

Yes, this was intentional from the get-go because we didn't have a clean separation between file sync and debug, and the whole filewatcher is turned off for debug:
https://github.com/GoogleContainerTools/skaffold/blob/master/cmd/skaffold/app/cmd/debug.go#L39
@briandealwis can share a bit more about the plans, but I think this should be possible.

@briandealwis
Copy link
Member

Hi @bmcstdio. debug disables the file watcher because it's really awkward have a process call stack in the debugger be torn down because you saved a change (triggering a rebuild and redeploy, causing the container and process being killed).

debug should use the newer mechanisms to disable the auto build so that it can be overridden or triggered externally though. I'll repurpose this bug for that.

@briandealwis briandealwis changed the title 'skaffold debug' should support "redeploy-on-change" 'skaffold debug' should support build triggers Nov 20, 2019
@tstromberg
Copy link
Contributor

@briandealwis - are you aware of any progress on this?

@briandealwis briandealwis self-assigned this Apr 30, 2020
@briandealwis
Copy link
Member

Yeah, I have to write a test. In progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/debug kind/feature-request priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants