Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skaffold should provide a stopEvent #3614

Open
briandealwis opened this issue Jan 30, 2020 · 0 comments
Open

Skaffold should provide a stopEvent #3614

briandealwis opened this issue Jan 30, 2020 · 0 comments
Labels
area/eventing kind/todo implementation task/epic for the skaffold team

Comments

@briandealwis
Copy link
Member

When Skaffold is started, it provides a start-event (though not programmatically identifiable):

{
  "result": {
    "timestamp": "2020-01-30T16:56:47.256487Z",
    "event": {
      "metaEvent": {
        "entry": "Starting Skaffold: &{Version: ConfigVersion:skaffold/v2alpha3 GitVersion: GitCommit: GitTreeState: BuildDate: GoVersion:go1.13.4 Compiler:gc Platform:darwin/amd64}"
      }
    }
  }
}

But there's no explicit tear-down event. It would be useful for any clients to differentiate between the socket being dropped for some reason (unlikely as it is) vs Skaffold being stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing kind/todo implementation task/epic for the skaffold team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants