Fail fast in Helm Templated fields

[msonnleitner]

Expected behavior

There is a closed issue/PR #2793 which implements fail fast behaviour a for a specific field: EnvTemplate. Therefore, for consistency other templated field might also fail fast for consistency.

Actual behavior

When starting helm deployment without the given env variable using
skaffold run

it results in helm errors

Helm release <no value>-service not installed. Installing...
Error: create: failed to create: Secret "sh.helm.release.v1.<no value>-service.v1" is invalid: [metadata.name: Invalid value: 
"sh.helm.release.v1.<no value>-service.v1": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*'), metadata.labels: Invalid value: "<no value>-service": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')]

Information

• Skaffold version: v1.17.0
• Operating system: MacOS Catalina
• Contents of skaffold.yaml:

apiVersion: skaffold/v2beta8
kind: Config
metadata:
  name: some-service
build:
  artifacts:
    - image: eu.gcr.io/tools-org/some-service
      docker:
        dockerfile: Dockerfile
deploy:
  helm:
    releases:
      - name: "{{.ISTIO_SUBSET}}-some-service"
        chartPath: helm/some-service
        artifactOverrides:
          image: eu.gcr.io/tools-org/some-service
        setValueTemplates:
          istio.version: "{{.ISTIO_SUBSET}}-v1"
      - name: "{{.ISTIO_SUBSET}}-some-service-istio"
        chartPath: helm/istio
        setValueTemplates:
          context: "{{.ISTIO_SUBSET}}"