Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider extending default status check timeout #5106

Closed
fsladkey opened this issue Dec 3, 2020 · 4 comments · Fixed by #5247
Closed

Consider extending default status check timeout #5106

fsladkey opened this issue Dec 3, 2020 · 4 comments · Fixed by #5247
Assignees
@MarlonGamez
Labels
internal kind/friction Issues causing user pain that do not have a workaround kind/todo implementation task/epic for the skaffold team priority/p1 High impact feature/bug.
Milestone
v1.18.0

Comments

@fsladkey
Copy link

fsladkey commented Dec 3, 2020

Consider extending default status check timeout

After discussing some deployments that (due to automatic cluster scaling) often took longer than the two minute status-check timeout, @tejal29 mentioned that because status checks now fail deployments immediately if they encounter an irrecoverable error, it may be desirable to extend the default status check timeout. Creating this issue for further discussion.
@tejal29 tejal29 added internal kind/friction Issues causing user pain that do not have a workaround kind/todo implementation task/epic for the skaffold team priority/p1 High impact feature/bug. labels Dec 7, 2020
@tejal29 tejal29 added this to the v1.18.0 milestone Dec 7, 2020
@tejal29
Copy link
Contributor

tejal29 commented Dec 7, 2020

Thanks @fsladkey for opening the issue. I have added this in next milestone.

@tejal29
Copy link
Contributor

tejal29 commented Jan 19, 2021 •
edited
Loading

Sorry this slipped my attention.
I will try to see if we can make this happen this release.
/cc @gsquared94 , @nkubala , @marlon-gamez @IsaacPD any takers?

@MarlonGamez
Copy link
Contributor

@tejal29 I can work on this 👍 do we have an idea of what the default timeout should be set to?

@MarlonGamez MarlonGamez self-assigned this Jan 19, 2021
@tejal29
Copy link
Contributor

tejal29 commented Jan 19, 2021

The default time should be 10 mins which is the default for deployments to stabilize.
https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#failed-deployment

@MarlonGamez MarlonGamez mentioned this issue Jan 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarlonGamez MarlonGamez

Labels
internal kind/friction Issues causing user pain that do not have a workaround kind/todo implementation task/epic for the skaffold team priority/p1 High impact feature/bug.
Projects
None yet
Milestone
v1.18.0
Development

Successfully merging a pull request may close this issue.

change default status check timeout to 10 minutes MarlonGamez/skaffold
3 participants
@tejal29 @fsladkey @MarlonGamez