Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Status Code name instead of number in our error metrics #5349

Closed
IsaacPD opened this issue Feb 4, 2021 · 0 comments · Fixed by #5350
Closed

Use Status Code name instead of number in our error metrics #5349

IsaacPD opened this issue Feb 4, 2021 · 0 comments · Fixed by #5350
Labels
area/metrics Metrics tracking work for skaffold kind/feature-request priority/p2 May take a couple of releases

Comments

@IsaacPD
Copy link
Contributor

IsaacPD commented Feb 4, 2021

Expected behavior

Metrics have error labels that show the name of the error e.g.error : OK and error : DEPLOY_LIST_MANIFEST_ERR

Actual behavior

error labels only use the number e.g error : 0 or error : 1014

skaffold/pkg/skaffold/instrumentation/export.go

Line 152 in e66f04c

label.String("error", strconv.Itoa(int(meter.ErrorCode))),

@IsaacPD IsaacPD added the area/metrics Metrics tracking work for skaffold label Feb 4, 2021
@IsaacPD IsaacPD mentioned this issue Feb 4, 2021
Merged
@MarlonGamez MarlonGamez added kind/feature-request priority/p2 May take a couple of releases labels Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/metrics Metrics tracking work for skaffold kind/feature-request priority/p2 May take a couple of releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use status code string in error label IsaacPD/skaffold
2 participants
@MarlonGamez @IsaacPD