Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Implement fixes for misconfigurations in user Dockerfile #6103

Closed
aaron-prindle opened this issue Jun 29, 2021 · 2 comments · Fixed by #6793
Closed

[FR] Implement fixes for misconfigurations in user Dockerfile #6103

aaron-prindle opened this issue Jun 29, 2021 · 2 comments · Fixed by #6793
Assignees
Labels
area/init kind/feature-request kind/todo implementation task/epic for the skaffold team planning/Q4-21 Q4 2021 planning priority/p1 High impact feature/bug.
Milestone

Comments

@aaron-prindle
Copy link
Contributor

Implement top 2 recommendations for misconfigurations in users dockerfile

@aaron-prindle aaron-prindle added kind/todo implementation task/epic for the skaffold team planning/Q3-21 labels Jun 29, 2021
@aaron-prindle aaron-prindle self-assigned this Jun 29, 2021
@aaron-prindle aaron-prindle changed the title Implement fixes for misconfigurations in user Dockerfile [FR] Implement fixes for misconfigurations in user Dockerfile Jun 30, 2021
@tejal29
Copy link
Contributor

tejal29 commented Jul 1, 2021

Nice! thanks for creating this issue. The first one we want to recommend is:

  1. If Dockerfile exists at root of the project with Copy . . exists, flag it. Reason being

    • It watches all .git, .vscode, .idea and
    • If user still wants to add Copy . . prompt user to add these files in .Dockerfileignore
  2. Go through Best practices for docker and pick one
    https://docs.docker.com/develop/develop-images/dockerfile_best-practices/

@aaron-prindle
Copy link
Contributor Author

Added tracking issue for DD for recommendation system here - #6122

@tejal29 tejal29 added this to the v1.30.0 milestone Jul 1, 2021
@tejal29 tejal29 added planning/Q4-21 Q4 2021 planning and removed planning/Q3-21 labels Sep 15, 2021
@tejal29 tejal29 removed this from the v1.30.0 milestone Sep 15, 2021
@tejal29 tejal29 added this to the v1.37.0 milestone Oct 13, 2021
@aaron-prindle aaron-prindle modified the milestones: v1.37.0, v1.36.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/init kind/feature-request kind/todo implementation task/epic for the skaffold team planning/Q4-21 Q4 2021 planning priority/p1 High impact feature/bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants