Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] Support for multiple values files for a helm release #672

Closed
stevenbarragan opened this issue Jun 11, 2018 · 2 comments
Closed

Comments

@stevenbarragan
Copy link

stevenbarragan commented Jun 11, 2018

I'm trying to use skaffold with helm secrets and besides other things it generates a decrypted yaml file to pass to helm, for example to do an upgrade.

helm upgrade -f values-file.yaml -f decrypted-values-file.yaml.dec ...

Actual behavior

...
deploy:
  helm:
    releases:
      - chartPath: chart
        valuesFilePath: chart/values-qa.yaml
...

Proposed behavior

...
deploy:
  helm:
    releases:
      - chartPath: chart
        valuesFilePath:
          - chart/values-qa.yaml
          - chart/other-values.yaml
...

Each file under the valuesFilePath will be passed to helm.

I dig into the code, it seems kind of straight forward but I'm not too familiar with go, it seems that the part that needs to be updated will be helm.go#L146, is there a way to set this key to either an string or an array and make it work both ways? if not, should we add a valuesFilePaths to support an array since it'd a breaking change?

@RoryShively
Copy link
Contributor

RoryShively commented Oct 18, 2018

I just opened an issue to continue the work on getting helm-secrets to work with skaffold
#1178

@nkubala
Copy link
Contributor

nkubala commented Nov 30, 2018

This was fixed through #985!

@nkubala nkubala closed this as completed Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants