Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build/bazel): support OCI ImageIndex tarballs #9219

Conversation

ar3s3ru
Copy link
Contributor

@ar3s3ru ar3s3ru commented Dec 12, 2023

Fixes: #9217

Description

User facing changes (remove if N/A)

Follow-up Work (remove if N/A)

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: Patch coverage is 33.72093% with 57 lines in your changes missing coverage. Please review.

Project coverage is 63.57%. Comparing base (290280e) to head (e2d3313).
Report is 1269 commits behind head on main.

Files with missing lines Patch % Lines
pkg/skaffold/build/bazel/build.go 33.72% 49 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9219      +/-   ##
==========================================
- Coverage   70.48%   63.57%   -6.92%     
==========================================
  Files         515      632     +117     
  Lines       23150    32622    +9472     
==========================================
+ Hits        16317    20738    +4421     
- Misses       5776    10284    +4508     
- Partials     1057     1600     +543     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mepi262
Copy link

mepi262 commented Jan 22, 2025

@ar3s3ru
It seems that this branch has conflicts.
Would you resolve it?

@ar3s3ru
Copy link
Contributor Author

ar3s3ru commented Jan 22, 2025

@mepi262 this was merely a draft PR where I tried different things to see how far I could get - spoiler: I didn't get anywhere.

So I think it's better to close the PR, and leave the issue open to track the feature request.

@ar3s3ru ar3s3ru closed this Jan 22, 2025
@ar3s3ru ar3s3ru deleted the feat/support-oci-image-json-bazel branch January 22, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for multi-arch OCI image indexes in Bazel builder
2 participants