Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data race in tar.go #9308

Closed
idsulik opened this issue Feb 10, 2024 · 0 comments · Fixed by #9309
Closed

Data race in tar.go #9308

idsulik opened this issue Feb 10, 2024 · 0 comments · Fixed by #9309

Comments

@idsulik
Copy link
Contributor

idsulik commented Feb 10, 2024 •
edited
Loading

Expected behavior

No data race

Actual behavior

WARNING: DATA RACE
Read at 0x00c0000b0040 by goroutine 469:
  archive/tar.(*regFileWriter).logicalRemaining()
      <autogenerated>:1 +0x38
  archive/tar.(*Writer).Flush()
      /usr/local/go/src/archive/tar/writer.go:53 +0x5c
  archive/tar.(*Writer).Close()
      /usr/local/go/src/archive/tar/writer.go:478 +0xa4
  github.com/GoogleContainerTools/skaffold/v2/pkg/skaffold/util.CreateTar.func1()
      /Users/main/Development/idsulik/skaffold/pkg/skaffold/util/tar.go:53 +0x34

Information

  • Skaffold version: v1.38.0-807-g6c5ca638a-dirty
  • Operating system: mac os
  • Installed via: built using source code

Steps to reproduce the behavior

  1. cd pkg/skaffold/util
  2. go test -race -count 5 ./

First seen here https://github.com/GoogleContainerTools/skaffold/actions/runs/7853592263/job/21433391917?pr=9307
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tar): data race fix idsulik/skaffold
1 participant
@idsulik