Hi @swissspidy !
We should also prerender the stories when a stories block is added to the front end. I was wondering what hook I could use for the same, to attach the load_rules method.

We should also prerender the stories when a stories block is added to the front end. I was wondering what hook I could use for the same, to attach the load_rules method.

The right hook to print the rules on the frontend would be wp_footer. Note: we should not print anything on the frontend if the plsr_print_speculation_rules function exists (which means the Speculation Rules plugin already handles this for us).

However, the stories on the frontend all open in a lightbox using amp-story-player, so I don't think it makes sense to add a rule for those, as it won't have an effect (please correct me if I'm wrong). What we could add a rule for is the "View all stories" link that is displayed below the stories.

That said: What I don't like about just hooking into wp_footer is that it means the admin-only Dashboard class (which is a dependency of the Speculative_Rendering class right now) gets loaded on the frontend as well, which is not intended.

That means we would need to design Speculative_Rendering in a slightly different way to decouple admin and frontend. For example, Speculative_Rendering could just print the script tag and have a filterable list of rules, and then all the relevant services or classes would filter the list instead. But not sure I like that, especially since the Renderer classes are not singletons, and ideally we would only add the filter once.
But this way we would make things more compatible with the Speculation Rules plugin in the long term.

➡️ Long story short, maybe let's hold off on any frontend stuff for now and focus on the admin side of things.

The quickEdit test is failing here too. Debugged it, and it seems the response returned here is 403.

This test logs in as author, but doing the same manually does not return a 403.

@swissspidy WDYT could be going wrong here?

Are speculation rules added on that page and Is the browser perhaps preloading the link? Maybe that causes some issues?
The error says response is null, which is suspicious.

Could be that a simple Puppeteer update fixes this, but we have some more errors on that PR 🙃

The E2E tests aren't going past the pendingStories test.

@swissspidy @AnuragVasanwala

OK so we have some timeouts apparently? yay fun 🙃

Can you try updating all our Puppeteer/e2e related dependencies (maybe in a new PR)? Just so that the browser we use during tests understands the speculation rules correctly.

The whole situation with this breaking Puppeteer in some weird way is not great. If we can't figure that out then it needs to stay on hold. In the meantime, people can use the Speculation Rules plugin 🤷

The whole situation with this breaking Puppeteer in some weird way is not great. If we can't figure that out then it needs to stay on hold. In the meantime, people can use the Speculation Rules plugin 🤷

Unfortunately, the Speculation Rules plugin does not pre-render any admin URLs, so we'll have to give up on instant editor loading :(

Unfortunately, the Speculation Rules plugin does not pre-render any admin URLs

It will get there eventually. There is also an open issue to make the config filterable by other plugins.