Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump WP version requirement to 6.4+ #13703

Closed
5 of 6 tasks
swissspidy opened this issue May 30, 2024 · 0 comments · Fixed by #13731
Closed
5 of 6 tasks

Bump WP version requirement to 6.4+ #13703

swissspidy opened this issue May 30, 2024 · 0 comments · Fixed by #13731
Assignees
Labels
Group: WordPress Changes related to WordPress or Gutenberg integration P2 Should do soon Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Task Tasks which do not involve engineering
Milestone

Comments

@swissspidy
Copy link
Collaborator

swissspidy commented May 30, 2024

Analytics numbers look good, so by the time we release our new version, only very few people will be on older versions.

Previously:

Field guide: https://make.wordpress.org/core/2023/10/23/wordpress-6-4-field-guide/

Some of the changes around option autoloading are nice. New functions get_options(), wp_prime_option_caches(), and wp_set_option_autoload_values() allow an enhanced performance of retrieving options from the database. This would help unblock #13701.

Post meta revisions are also useful. In the Story_Post_Type class we can use the wp_post_revision_meta_keys filter to ensure POSTER_META_KEY and PUBLISHER_LOGO_META_KEY are part of revisions too. Might require some testing. Ditto for the Product_Meta class

Nothing else stands out at the moment.

Tasks include:

  • Bump in readme.txt
  • Bump in web-stories.php (twice)
  • Update minimum_supported_wp_version in phpcs.xml.dist
  • Run e2e tests against 6.4 and newer
  • Run unit tests against 6.4 and newer
  • Re-evaluate PHPUnit matrix and composer dependencies if necessary
@swissspidy swissspidy added P2 Should do soon Type: Task Tasks which do not involve engineering Group: WordPress Changes related to WordPress or Gutenberg integration Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ labels May 30, 2024
@swissspidy swissspidy added this to the 1.37.0 milestone May 30, 2024
@swissspidy swissspidy modified the milestones: 1.37.0, 1.38.0 Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: WordPress Changes related to WordPress or Gutenberg integration P2 Should do soon Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Type: Task Tasks which do not involve engineering
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants