Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure: update to webpack v5 #6304

Closed
swissspidy opened this issue Feb 10, 2021 · 6 comments · Fixed by #5792
Closed

Infrastructure: update to webpack v5 #6304

swissspidy opened this issue Feb 10, 2021 · 6 comments · Fixed by #5792
Assignees
@samwhale @felipebochehin87
Labels
P3 Nice to have Type: Infrastructure Changes impacting testing infrastructure or build tooling

Comments

@swissspidy
Copy link
Collaborator

Task Description

webpack 5 contains a ton of improvements and bug fixes, and will also help in our endeavour to further optimize our bundles. There are some caveats though. See #5792 for more info.
@swissspidy swissspidy added P2 Should do soon Status: Blocked On hold for the time being Type: Infrastructure Changes impacting testing infrastructure or build tooling Pod: WP & Infra labels Feb 10, 2021
@swissspidy swissspidy mentioned this issue Feb 10, 2021
Merged
@swissspidy swissspidy added P3 Nice to have and removed P2 Should do soon labels May 19, 2021
@swissspidy
Copy link
Collaborator Author

@BrittanyIRL This one is at the interesction of Karma and performance improvements, perhaps another thing that Pea pod wants to look into?

#5792 has the WIP for this.

@BrittanyIRL
Copy link
Contributor

@BrittanyIRL This one is at the interesction of Karma and performance improvements, perhaps another thing that Pea pod wants to look into?

#5792 has the WIP for this.

Sure! This will be a big one but it would be so great to complete.

@BrittanyIRL BrittanyIRL added Pod: Pea and removed Status: Blocked On hold for the time being labels Jan 11, 2022
@swissspidy
Copy link
Collaborator Author

The good thing is the majority of the work should done, what's left is fixing the storybook and — surprise — Karma tests. Admittedly, it still might take some time to crack these two.

@swissspidy
Copy link
Collaborator Author

cc @merapi as you might have some ideas on how to fix the Karma tests in #5792 - the PR has all the details

@swissspidy
Copy link
Collaborator Author

Regarding the open todos on #5792: One of the storybook issues might be fixed by v6.5.0-alpha.23, see storybookjs/storybook#14877 (comment)

@swissspidy swissspidy mentioned this issue Feb 7, 2022
Merged
8 tasks
@swissspidy swissspidy mentioned this issue Feb 23, 2022
Closed
@samwhale samwhale mentioned this issue Feb 23, 2022
Closed
@felipebochehin87 felipebochehin87 self-assigned this Feb 28, 2022
@felipebochehin87
Copy link

Tested against https://stories-qa-wordpress-amp.pantheonsite.io/wp-admin/, using PR #5792.

Regressed/smoke tested editor:

  1. Created new story
  2. Updated existing one
  3. Added images/videos/shapes/text
  4. Updated colors, layouts
  5. Preview
  6. Tested checklist
  7. Published
  8. Added and remove links, background images

Working as expected.

@samwhale samwhale mentioned this issue Mar 10, 2022
Closed
@samwhale samwhale mentioned this issue Apr 1, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samwhale samwhale

@felipebochehin87 felipebochehin87

Labels
P3 Nice to have Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Infrastructure: Update build tooling to use webpack v5 GoogleForCreators/web-stories-wp
4 participants
@swissspidy @BrittanyIRL @samwhale @felipebochehin87