-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Replace Template Stories with Images #8373
Comments
The discussion at https://github.com/google/web-stories-wp/pull/8274/files#r670841347 mentioned that the template preview images should be like poster images, without author, title, etc. in it. But is that correct? IMO the preview should be === the cover page, ≠ the poster image. So it should include all those elements. (cc @choumx) That would make creation of these preview images much easier as it basically just means taking a screenshot. I am not sure we can just grab the images from Figma though as the aspect ratio might be different. But perhaps there's another easy way to generate these? I'll talk to the templates team to hear their thoughts.
I think it would be OK to keep this part as-is for now One disadvantage of the animated previews is that they are not super accurate. Text is usually displayed way bigger. (Can we fix that?) If the animated previews don't provide much value, we could consider getting rid of them and only displaying static images. Alternative 1: We could look into showing preview images and loading the animated previews with a small delay. So that when I am only quickly browsing through templates it's much faster. Alternative 2: Use small videos for the previews instead. Note: Also worth thinking about doing the same for page templates in the editor. #7985 is related. |
Thanks, Pascal. I didn't mean to spread confusion by using the word I know Marcin did some exploration to generate PNGs (re text sets that could also be used here probably) (#8117) but I'm wondering if we need a substitute in the meantime or just let it be. If we do want to just let it be for now, perhaps we just load the first page of the story and remove the hover/focus so it never "plays". Aesthetically, it's a little weird to me to have the my stories grid and templates be different ratios and I'd like to bring consistency sooner rather than later. Re detail view, I would be curious if anyone would miss the animations not playing. I'll wait for Will to chime in here but my 2 cents are that since the display is inaccurate we should either cut it or fix it. That page has been super neglected for a while, so it'd be nice to give it some polish either way. |
I think this would be good to knock out. I'm drawing a blank trying to figure out the best way to get the proper aspect ratio on these images. |
Chatted with @divyarajmasani and we were wondering whether we could open the templates as proper stories in the browser and then take screenshots with Puppeteer. Something like this:
Or even better, but not sure if possible:
But I assume AMP complains if not run on localhost or a proper host.
Since these are also used in the carousel in the editor, could you create a new ticket for it and perhaps sync with Morten on it? He might have some ideas there. |
this feels alot like what @merapi was trying out with text sets: #7985 (comment) |
But if we just want a screenshot of the first page and preserve the animated view on hover, we can use the same technique as in the text sets. |
Amazing! That makes it pretty straightforward
I'd really love it if we could do without animations, because it means we could avoid using |
The 'my stories' view is now void of animations, i say we gut them from templates! |
This should have been an epic 😞 Sorry @bmattb . For transparency since it's a little too late to correct the issue structure.
At this point, we can also start discussion of swapping out page templates in the editor for images. This won't help custom page templates at all but it'd cut down on the load. |
Verified in QA |
TBD on how we do this.
Based on the conversation here: https://github.com/google/web-stories-wp/pull/8274/files#r670841347
Templates in the dashboard are actual stories that are loading. we recently updated the my stories view to use the poster image of a story (#8274). Templates currently don't have poster image to use for this.
This ticket is to work through how we want to create image assets for templates and then implement that for existing templates and update the template creation process so that future templates have this built in.
Other questions:
The text was updated successfully, but these errors were encountered: