Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node v8.10.0 error #29

Closed
ghost opened this issue Mar 27, 2018 · 7 comments
Closed

node v8.10.0 error #29

ghost opened this issue Mar 27, 2018 · 7 comments

Comments

@ghost
Copy link

ghost commented Mar 27, 2018

Hello.
After a few months i ran one project of mine.
I'm using child_pty and i get

tasoss@devtrans:~/nodetest$ node a.js
node[21184]: ../src/pipe_wrap.cc:131:static void node::PipeWrap::New(const v8::FunctionCallbackInfov8::Value&): Assertion `args[0]->IsInt32()' failed.
1: node::Abort() [node]
2: 0x11e77db [node]
3: node::PipeWrap::New(v8::FunctionCallbackInfov8::Value const&) [node]
4: v8::internal::FunctionCallbackArguments::Call(void ()(v8::FunctionCallbackInfov8::Value const&)) [node]
5: 0xb7a2cf [node]
6: v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate
) [node]
7: 0x39bafe8042fd
Aborted (core dumped)

I don't know if it's related to nodejs/node#12152
Is there any chance to correct it because i use child_pty on some major parts of my app.
Thanks!

@Gottox
Copy link
Owner

Gottox commented Mar 27, 2018

What's the content of a.js?

@Gottox
Copy link
Owner

Gottox commented Mar 27, 2018

Ah, can reproduce with the tests.

@ghost
Copy link
Author

ghost commented Mar 27, 2018

Hello and thx for replying!
The content is a test file

var child_pty = require('child_pty');
var child = child_pty.spawn('/bin/sh', []);
child.stdout.on('resize', function() {
console.log('New columns: ' + this.columns);
console.log('New rows: ' + this.rows);
}).pipe(process.stdout);
child.stdout.resize({ columns: 80, rows: 48 });
child.stdin.write('ls -l\n');
child.stdin.write('exit\n');

This is a sample that exists in README.
Waiting for some good news :)
Thanks!

@Gottox
Copy link
Owner

Gottox commented Mar 27, 2018

Fixed in the v3 branch. I'm waiting for travis and then release v3.0.8.

@Gottox
Copy link
Owner

Gottox commented Mar 27, 2018

There are some deprecation warnings during the tests, but I'll fix them later.

@Gottox
Copy link
Owner

Gottox commented Mar 27, 2018

fixed in v3.0.8

@Gottox Gottox closed this as completed Mar 27, 2018
@ghost
Copy link
Author

ghost commented Mar 27, 2018

Thank you very much!!! Really!
ps: if you find some free time please correct those warning , i have seen them too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant