Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some dependencies should be devDependencies. #11

Closed
garronej opened this issue Sep 9, 2024 · 2 comments · Fixed by #17
Closed

Some dependencies should be devDependencies. #11

garronej opened this issue Sep 9, 2024 · 2 comments · Fixed by #17

Comments

@garronej
Copy link

garronej commented Sep 9, 2024

Hello,

Thank you for creating this package!

@K4ST0R recently integrated it into react-dsfr: Example.

However, we've noticed that installing @gouvfr/chart-dsfr brings in around 250 additional packages, resulting in a total size of about 200MB in the node_modules folder.

To optimize this, it would be beneficial to move certain dependencies, such as sass, to the devDependencies list.

Best regards,

@zellerbaptiste
Copy link
Contributor

Merci pour le retour @garronej nous allons nous pencher sur le sujet et voir ce qui peut être amélioré en ce sens pour la prochaine release.

@garronej
Copy link
Author

garronej commented Oct 1, 2024

Top merci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants