Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text inside Masthead component doesn't render as single line on iPhone SE screen size #193

Closed
2 tasks done
jmalvinez opened this issue May 16, 2024 · 2 comments
Closed
2 tasks done
Labels
documentation Improvements or additions to documentation

Comments

@jmalvinez
Copy link

Prerequisites

Describe the issue

Hi team, the text inside the Masthead component doesn't render as a single line on iPhone SE screen size.

Steps to reproduce

  1. On Chrome, go to Masthead component in Storybook.
  2. Switch to iPhone SE screen size using Chrome dev tools.

Expected behaviour
Text inside Masthead component is rendered as a single line similar to the behaviour in the deprecated @govtechsg/sgds-masthead-react package.

Actual behaviour
Text inside Masthead component is rendered as two lines.
Masthead_iPhoneSE

What operating system(s) are you seeing the problem on?

macOS

What browser(s) are you seeing the problem on?

Chrome

Describe your frontend stack. What version of React and @govtechsg/sgds-web-component are you using? CSR or SSR?

React v18.2.0, @govtechsg/sgds-web-component v1.0.2

@jmalvinez jmalvinez added the bug Something isn't working label May 16, 2024
@clukhei
Copy link
Collaborator

clukhei commented May 17, 2024

Screenshot 2024-05-17 at 10 38 05 AM

@jmalvinez Hi I would say the masthead itself does not have a bug. Its looking like that due to the additional padding from Storybook's default container padding. We will see what we can do to remove the container paddings in the documented page, but the component itself is working fine. See the screenshot above where i remove storybook's padding in iphone SE size

@clukhei clukhei added documentation Improvements or additions to documentation and removed bug Something isn't working labels May 17, 2024
@clukhei
Copy link
Collaborator

clukhei commented Oct 25, 2024

Closing this as it will be fixed in the version 3 of storybook documentation

@clukhei clukhei closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants