-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom should be called when chart is applicable for it #125
Comments
Thank you for create an issue for your problem, this helps a lot. I was not able to reproduce your problem, can you please adopt this plnkr to show me when it fails. |
@maxklenk I managed to reproduce it but including one more dependency - |
puh, I see. Interesting bug, we should check if destruction of the chart is not finished and is responsible for this strange behavior. If you find a solution please tell me. |
Like I told you I traced it to the Maybe this |
I asked my question in #89, but since it's closed I think I should submit it as an issue, so I'm moving my comment here.
I think I have a problem with the check you dropped for the zoom in v0.3.2.
I have a pie chart that gets redrawn because of this zoom and I receive following error in c3:
I don't think pie charts are applicable for zoom, so why to redraw the chart once again?
Maybe the problem is somewhere else but this is where I got so far.
@maxklenk Could you please check this? I also tested c3 only without
angular-chart
and withoutangular
and could not reproduce the error.At the point when
applyZoom
is called and the error happens I have abaseConfiguration
that's basically an empty object - nodata['json']
, nodata['types']
, which causes thec3
crash.The text was updated successfully, but these errors were encountered: