Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 6.6.1 still reports shadowJar has a forward-incompatibility with Gradle 7.0 #601

Closed
rdesgroppes opened this issue Sep 24, 2020 · 8 comments · Fixed by #647
Closed

Comments

@rdesgroppes
Copy link

rdesgroppes commented Sep 24, 2020

This is to report that, despite all the good work to address #530, there seems to be a leftover Property 'transformers.$1.data' is not annotated with an input or output annotation.

Shadow Version

id 'com.github.johnrengelman.shadow' version '6.1.0'

Gradle Version

------------------------------------------------------------
Gradle 6.6.1
------------------------------------------------------------

Build time:   2020-08-25 16:29:12 UTC
Revision:     f2d1fb54a951d8b11d25748e4711bec8d128d7e3

Kotlin:       1.3.72
Groovy:       2.5.12
Ant:          Apache Ant(TM) version 1.10.8 compiled on May 10 2020
JVM:          1.8.0_265 (Private Build 25.265-b01)
OS:           Linux 5.4.0-47-generic amd64

Expected Behavior

No forward-incompatibility with Gradle 7.0.

Actual Behavior

$ ./gradlew --debug assemble
...
[LIFECYCLE] [class org.gradle.internal.buildevents.TaskExecutionLogger] > Task :my:shadowJar UP-TO-DATE
[DEBUG] [org.gradle.internal.operations.DefaultBuildOperationExecutor] Build operation 'Task :my:shadowJar' started
[DEBUG] [org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter] Putting task artifact state for task ':my:shadowJar' into context took 0.0 secs.
[WARN] [org.gradle.internal.featurelifecycle.LoggingDeprecatedFeatureHandler] Property 'transformers.$1.data' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.6.1/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
[DEBUG] [org.gradle.internal.operations.DefaultBuildOperationExecutor] Build operation 'Snapshot inputs and outputs before executing task ':my:shadowJar'' started
...

Gradle Build Script(s)

plugins {
...
    id 'com.github.johnrengelman.shadow' version '6.1.0' apply false
...
}
...
project(':my') {
...
    apply plugin: 'com.github.johnrengelman.shadow'
...
    shadowJar {
        mergeServiceFiles()
        append('my.conf')
    }
...
}
@boris-petrov
Copy link

boris-petrov commented Dec 9, 2020

@johnrengelman - I understand that Gradle 7 is coming very soon so it would be nice to have these fixed for Gradle Shadow to work with it.

P.S. That's what I get:

Property 'transformers.$2.data' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.7/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
Property 'transformers.$3.doc' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.7/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.
Property 'transformers.$3.ignoreDtd' is not annotated with an input or output annotation. This behaviour has been deprecated and is scheduled to be removed in Gradle 7.0. See https://docs.gradle.org/6.7/userguide/more_about_tasks.html#sec:up_to_date_checks for more details.

@liutikas
Copy link
Contributor

liutikas commented Mar 5, 2021

Our team is seeing this as well. Any chance we can get an update?

> Task :wear:wear-tiles-proto:shadowJar
Execution optimizations have been disabled for task ':wear:wear-tiles-proto:shadowJar' to ensure correctness due to the following reasons:
  - Type 'ShadowJar': property 'transformers.$0.resource' is not annotated with an input or output annotation.

> Task :work:work-inspection:shadowDependenciesRelease
Execution optimizations have been disabled for task ':work:work-inspection:shadowDependenciesRelease' to ensure correctness due to the following reasons:
  - Type 'ShadowJar': property 'transformers.$0.renamed' is not annotated with an input or output annotation.

> Task :compose:ui:ui-inspection:shadowDependenciesRelease
Execution optimizations have been disabled for task ':compose:ui:ui-inspection:shadowDependenciesRelease' to ensure correctness due to the following reasons:
  - Type 'ShadowJar': property 'transformers.$0.renamed' is not annotated with an input or output annotation.

@effad
Copy link

effad commented Mar 25, 2021

We are in the process of migrating to Gradle 7 and are affected by this problem. ShadowJar doesn't work with Gradle 7.0-rc-1:

@liutikas
Copy link
Contributor

Is there an ETA for a release of the plugin with this fix? It would be very helpful to us to continue testing Gradle 7.0

@effad
Copy link

effad commented Apr 29, 2021

I've seen that there is a 7.0.0 release of shadowJar now and according to https://plugins.gradle.org/plugin/com.github.johnrengelman.shadow this is the latest version.
However, https://plugins.gradle.org/m2/com/github/jengelman/gradle/plugins/shadow/ does not (yet?) contain this version, which leads to this error when trying to use it:

A problem occurred configuring root project 'java'.

Could not resolve all artifacts for configuration ':classpath'.
Could not find com.github.jengelman.gradle.plugins:shadow:7.0.0.
Searched in the following locations:
- https://plugins.gradle.org/m2/com/github/jengelman/gradle/plugins/shadow/7.0.0/shadow-7.0.0.pom

Is this just a lag of the processes involved or did sth. go wrong in the release process?

@johnrengelman
Copy link
Collaborator

@effad you are looking in the wrong maven coordinates for 7.0.0. The group name changed for this version to fall in line with the idiomatic configuration for Gradle plugins (due to the jcenter shutdown).

This is show in the example on the plugin page here: https://plugins.gradle.org/plugin/com.github.johnrengelman.shadow/7.0.0

The correct location is:
https://plugins.gradle.org/m2/gradle/plugin/com/github/jengelman/gradle/plugins/shadow/

I will update the release notes to reflect this change.

@rdesgroppes
Copy link
Author

It works like a charm. Thanks, @johnrengelman!

@effad
Copy link

effad commented Apr 30, 2021

@effad you are looking in the wrong maven coordinates for 7.0.0. The group name changed for this version to fall in line with the idiomatic configuration for Gradle plugins (due to the jcenter shutdown).

Thanks for the hint, I was able to fix that. Will report new problems in separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants