Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

size limit for images in GO #1840

Closed
pgwid-og opened this issue Mar 14, 2024 · 6 comments · Fixed by #1843
Closed

size limit for images in GO #1840

pgwid-og opened this issue Mar 14, 2024 · 6 comments · Fixed by #1843

Comments

@pgwid-og
Copy link

Yesterday I tried to convert a new sample set (http://www.pipeloops.com//product_info.php?products_id=64) to GO. It uses bitmaps with the size 5760 x 3336, which is obviously too large for GO (afaik the max size is 4000). Since HD pictures are much bigger than the ones in old days, it might be the time to enlarge the upper limit for image sizes?
It is a bit annoying to rescale the images and calculate all the position parameters in the ODF again, although Lars' GoODF helps a bit with this job.
Oliver

@larspalo
Copy link
Contributor

If I remember correctly, the limit of the image size comes actually from the limit of the panel size.

@larspalo
Copy link
Contributor

The size limit is imposed in GOConfigReader::ReadSize funcion. So to change it it's necessary to alter the file src/core/config/GOConfigReader.cpp line 544:

if (100 <= size && size <= 4000)

which is a no-brainer.

Given 8K UHD a raise to 8000 would currently be enough, but there are even higher resolutions available so 16000 or greater isn't out of the question. ;-)

@oleg68
Copy link
Contributor

oleg68 commented Mar 15, 2024

I would increase it to 30000

@larspalo
Copy link
Contributor

@oleg68 Then it should be 32000 to match the 4K increases that seems to be current screen resolution development.

@oleg68
Copy link
Contributor

oleg68 commented Mar 15, 2024

@oleg68 Then it should be 32000 to match the 4K increases that seems to be current screen resolution development.

OK

@pgwid-og
Copy link
Author

pgwid-og commented Mar 22, 2024

Thank you for the quick solution. I am looking forward to Version 3.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants