Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Undo (Ctrl+Z) is not cancelling browser keyboard shortcut #5325

Closed
2 tasks done
bohwaz opened this issue Aug 21, 2023 · 0 comments
Closed
2 tasks done

BUG: Undo (Ctrl+Z) is not cancelling browser keyboard shortcut #5325

bohwaz opened this issue Aug 21, 2023 · 0 comments

Comments

@bohwaz
Copy link

bohwaz commented Aug 21, 2023

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Vivaldi

Reproducible demo link

https://grapesjs.com/demo.html

Describe the bug

How to reproduce the bug?

  1. Press Ctrl+Z after doing an action, to undo it
  2. The action is reversed, but my browser also reopens the last closed tab

What is the expected behavior?

Stopping the browser from performing the default keybinding.

What is the current behavior?

Ctrl+Z event propagation is not stopped in JS, so the browser still performs the assigned keyboard shortcut.

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant