Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Wrong Type in ColorPickerOptions Interface #5739

Closed
2 tasks done
rhoenerSBS opened this issue Mar 11, 2024 · 0 comments
Closed
2 tasks done

BUG: Wrong Type in ColorPickerOptions Interface #5739

rhoenerSBS opened this issue Mar 11, 2024 · 0 comments

Comments

@rhoenerSBS
Copy link

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Chrome v122

Reproducible demo link

not applicable

Describe the bug

The ColorPicker Interface that came with the latest release, defines the "preferredFormat" option to expect a 'boolean' value but the docs of the Spectrum Colorpicker indicate it has to be type 'string' (Docs: https://bgrins.github.io/spectrum/#options-preferredFormat)
This leads to errors during compiling in TypeScript Projects.

How to reproduce the bug?

  1. define ColorPicker "preferredFormat" option with value from the Spectrum docs (i.e. "hex")
export const colorpickerConfig: Partial<EditorConfig> = {
    colorPicker: {
        preferredFormat: "hex"
    }
};

What is the expected behavior?
does compile

What is the current behavior?
type error

Code of Conduct

  • I agree to follow this project's Code of Conduct
@artf artf closed this as completed in 394dc14 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant