fix(react): simple elements not rendering (#45)

Co-authored-by: João Pedro Schmitz <oi@joaopedro.cc>
hygraph · Oct 19, 2021 · 5dd9acb · 5dd9acb
1 parent de02591
commit 5dd9acb
Show file tree

Hide file tree

Showing 4 changed files with 30 additions and 1 deletion.
diff --git a/.changeset/late-spiders-fold.md b/.changeset/late-spiders-fold.md
@@ -0,0 +1,5 @@
+---
+"@graphcms/rich-text-react-renderer": patch
+---
+
+fix(react): simple elements are not empty
diff --git a/packages/react-renderer/src/util/elementIsEmpty.ts b/packages/react-renderer/src/util/elementIsEmpty.ts
@@ -28,5 +28,5 @@ export function elementIsEmpty({
  return hasText.length > 0 ? false : true;
  } else if (children[0].text === '') return true;
 
- return true;
+ return false;
 }
diff --git a/packages/react-renderer/test/RichText.test.tsx b/packages/react-renderer/test/RichText.test.tsx
@@ -12,6 +12,7 @@ import {
  inlineContent,
  emptyContent,
  embedAssetContent,
+ simpleH1Content,
 } from './content';
 
 describe('@graphcms/rich-text-react-renderer', () => {
@@ -99,6 +100,18 @@ describe('@graphcms/rich-text-react-renderer', () => {
  `);
  });
 
+ it('should should render H1 with some text', () => {
+ const { container } = render(<RichText content={simpleH1Content} />);
+
+ expect(container).toMatchInlineSnapshot(`
+ <div>
+ <h1>
+ heading
+ </h1>
+ </div>
+ `);
+ });
+
  it('renders content with custom elements', () => {
  const { container } = render(
  <RichText

diff --git a/packages/react-renderer/test/content.ts b/packages/react-renderer/test/content.ts
@@ -141,6 +141,17 @@ export const emptyContent: RichTextContent = [
  },
 ];
 
+export const simpleH1Content: RichTextContent = [
+ {
+ type: 'heading-one',
+ children: [
+ {
+ text: 'heading',
+ },
+ ],
+ },
+];
+
 export const inlineContent: RichTextContent = [
  {
  type: 'paragraph',