Fix text node when pasting images; sanitize URLs

[oddtinker]

• Assign an image's src as the parsed node's text content. Children must be passed to the jsx function as the third argument. Previously, they were returned as part of the attrs object.

image.mp4

• Sanitize anchor's href, image's src

Resolves ENG-3787

[changeset-bot]

🦋 Changeset detected

Latest commit: 33d009e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@graphcms/html-to-slate-ast	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
packages/react-renderer/dist/rich-text-react-renderer.cjs.production.min.js	4.82 KB (0%)
packages/react-renderer/dist/rich-text-react-renderer.esm.js	4.78 KB (0%)
packages/types/dist/rich-text-types.cjs.production.min.js	51 B (0%)
packages/types/dist/rich-text-types.esm.js	64 B (0%)

[linear]

ENG-3787 Rich Text Editor: Fix pasting images

Report in Slack: https://graphcms-internal.slack.com/archives/C0240MKGSAJ/p1628496439008400

Use this Google Doc for testing: https://docs.google.com/document/d/1cood8Z3NsdN26O3Da37a40Qwk_GtlfnmRDn9tgzbEYo/edit

Relevant recent changes to the parser library: https://github.com/GraphCMS/rich-text/pull/23/files

Relevant recent changes in the webapp's Rich Text editor's normalizing method: https://github.com/GraphCMS/next-webapp/commit/1ea81f1bc5b66f73482625d7d4a6d7b5a700e003

Parser PR: #27

[okjulian]

Thanks for the fix Larisa. Code looks spot on!

May I ask if it's possible to add a new test case that calls htmlToSlateAST with an html representation of the image you copied on the video, and verifies that the correct AST is generated? That test should have failed before your fix, and pass now.

[okjulian]

Great fix, test and sanitizing addition 💯

[feychenie]