Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breaks, links, code block; Update Slate #34

Merged
merged 9 commits into from
Aug 31, 2021
Merged

Fix breaks, links, code block; Update Slate #34

merged 9 commits into from
Aug 31, 2021

Conversation

oddtinker
Copy link
Contributor

@oddtinker oddtinker commented Aug 24, 2021 •
edited
Loading

  • Wrap parentless breaks in a paragraph
  • Do not add thead to headless tables
  • Update Slate dependencies
  • Fix type set to parsed pre tags: was pre, must be code-block
  • Add test for pre tags
  • Refactor TS types

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 22787fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphcms/html-to-slate-ast Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Aug 24, 2021 •
edited
Loading

size-limit report 📦

Path Size
packages/react-renderer/dist/rich-text-react-renderer.cjs.production.min.js 4.91 KB (0%)
packages/react-renderer/dist/rich-text-react-renderer.esm.js 4.87 KB (0%)
packages/types/dist/rich-text-types.cjs.production.min.js 51 B (0%)
packages/types/dist/rich-text-types.esm.js 64 B (0%)

@oddtinker oddtinker changed the title Fix breaks, links Fix breaks, links; Update Slate Aug 27, 2021
@oddtinker oddtinker requested a review from a team August 30, 2021 07:49
@oddtinker oddtinker marked this pull request as ready for review August 30, 2021 07:49
@oddtinker oddtinker changed the title Fix breaks, links; Update Slate Fix breaks, links, code block; Update Slate Aug 31, 2021
@oddtinker oddtinker merged commit 5a618d5 into main Aug 31, 2021
@oddtinker oddtinker deleted the html-parser-links-breaks branch August 31, 2021 08:33
@github-actions github-actions bot mentioned this pull request Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Martian2Lee Martian2Lee Martian2Lee approved these changes

Assignees

@mahaveer0496 mahaveer0496

@oddtinker oddtinker

Labels
html-to-slate-ast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oddtinker @Martian2Lee @mahaveer0496